docs: correct default log retention - #218
Open
miachillgood wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Corrects the conflicting retention comment in the
0-bootstrapsample. The sample now states that Cloud Logging buckets uselogging_bucket_retention, whose default is 365 days, instead of incorrectly describing a 30-day default.Fixes #194
Type of Change
Deployment & Compliance Impact
Checklist
Code Quality & Reusability
modules/orfast/can be leveraged for this change.documentation/naming-convention.md.Not applicable: no code, modules, configuration values, or resource names change.
Documentation
README.mdof the modified module or blueprint.The existing variable description and sample now consistently document the same default.
Security
Not applicable: this documentation correction does not change deployed resources or security behavior.
Testing
Testing Performed
logging_bucket_retentiondefaults to 365 in the bootstrap variablesgit diff --check